fix(parser): handle quotes inside ${...} in double-quoted strings#483
Merged
fix(parser): handle quotes inside ${...} in double-quoted strings#483
Conversation
The lexer now tracks ${...} brace depth inside double-quoted strings
so that inner quotes (e.g. ${arr["key"]}) don't terminate the outer
string. Also strips surrounding quotes from array indices during parsing.
Closes #399
https://claude.ai/code/session_01WZjYqxm5xMPAEe7FSHJkDy
chaliy
force-pushed
the
claude/fix-399-Y2nIj
branch
from
a031674 to
03a299a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
${arr["key"]}inside double-quoted strings being misparsedread_double_quoted_stringdidn't track${...}brace depth, so inner"terminated the outer stringread_param_expansion_into()to track brace depth inside parameter expansionsCloses #399
Test plan